fix: no skip load actors for Forest#141
Merged
parthshah1 merged 1 commit intoFilecoinFoundationWeb:mainfrom Nov 21, 2025
Merged
fix: no skip load actors for Forest#141parthshah1 merged 1 commit intoFilecoinFoundationWeb:mainfrom
parthshah1 merged 1 commit intoFilecoinFoundationWeb:mainfrom
Conversation
Actors are cached in the Dockerfile anyway, there's no point in skipping them. Signed-off-by: Hubert <lesny.rumcajs+github@gmail.com>
Collaborator
|
LGTM!! Thank you for fixing this. Merging this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Actors are cached in the Dockerfile anyway; there's no need to skip them.
This is caused by ChainSafe/forest#6193, which operates on the bundles without ensuring they are loaded. To be fixed on the Forest side (or we can remove this flag to make things simpler).